Open arueckauer opened 5 years ago
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/12.
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
git rebase -i origin/{branch}
)
This PR provides changes described in #364
I have two questions from refactoring.
\Iterator::current()
is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.Iterator::current()
documents a mixed (any) typeAbstractResultSet::current()
documentsarray|null
ResultSet::current()
documentsarray|ArrayObject|null
HydratingResultSet::current()
documentsnull|array|bool
ExtractionInterface::extract()
expects parameter be of type object. From my understandingHydratingResultSet::toArray()
could give provide any ofnull|array|bool
. Not sure if I misunderstand it or if that needs some attention.