zendframework / zend-db

Db component from Zend Framework
BSD 3-Clause "New" or "Revised" License
101 stars 122 forks source link

Refactor of `Zend\Db\ResultSet` for 3.0.0 #370

Open arueckauer opened 5 years ago

arueckauer commented 5 years ago

This PR provides changes described in #364

I have two questions from refactoring.

  1. Return type hints for implementations of \Iterator::current() is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.
  1. ExtractionInterface::extract() expects parameter be of type object. From my understanding HydratingResultSet::toArray() could give provide any of null|array|bool. Not sure if I misunderstand it or if that needs some attention.
weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/12.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow: