zendframework / zend-di

Di component from Zend Framework
BSD 3-Clause "New" or "Revised" License
46 stars 29 forks source link

Add Logging To Code Generators (WIP) #32

Closed tux-rampage closed 6 years ago

tux-rampage commented 6 years ago

This will add logging capabilities to the code generators by implementing Psr\Log\LoggerAwareInterface. This will complete the stated TODO in the code.

Users will then be able to provide any logger that implements Psr\Log\LoggerInterface to the code generator classes:

$generator->setLogger($logger);
Ocramius commented 6 years ago

@tux-rampage this was opened and merged by yourself without any review approving or rejecting it. Please do not ever do that again.

tux-rampage commented 6 years ago

@Ocramius thanks for the info. I guess I was too eager then. I'll roll back the merge asap and reopen the pull for Review. Sorry about that.

Ocramius commented 6 years ago

@tux-rampage no need to roll back, just please ask for help if you feel like nobody watched over your work.