zendframework / zend-di

Di component from Zend Framework
BSD 3-Clause "New" or "Revised" License
46 stars 29 forks source link

Improve code quality #36

Closed tux-rampage closed 6 years ago

tux-rampage commented 6 years ago

The injector uses a hack/workaround and reflection to instanciate classes with multiple parameters. Since PHP 5.6 this is no longer necessary because of argument unpacking with the splat operator.

The constructor's phpdoc is incorrect and some functions were missing proper @throws tags as well.

This commit aims to improve the code quality and maintainability. All changed lines are covered by existing tests. It does not change the components behavior, adds features or fixes bugs.