Declare strict types

[tux-rampage]

All source files should declare strict types.

See Issue #41

• [ ] Are you fixing a bug?

  • [ ] Detail how the bug is invoked currently.
  • [ ] Detail the original, incorrect behavior.
  • [ ] Detail the new, expected behavior.
  • [ ] Base your feature on the master branch, and submit against that branch.
  • [ ] Add a regression test that demonstrates the bug, and proves the fix.
  • [ ] Add a CHANGELOG.md entry for the fix.

• [ ] Are you creating a new feature?

  • [ ] Why is the new feature needed? What purpose does it serve?
  • [ ] How will users use the new feature?
  • [ ] Base your feature on the develop branch, and submit against that branch.
  • [ ] Add only one feature per pull request; split multiple features over multiple pull requests
  • [ ] Add tests for the new feature.
  • [ ] Add documentation for the new feature.
  • [ ] Add a CHANGELOG.md entry for the new feature.

• [x] Is this related to quality assurance? This assures the common best practices of ZF components

• [ ] Is this related to documentation?

[Ocramius]

Before going here: are we on PHPStan level 7?

On Fri, 16 Nov 2018, 21:24 Axel H. <notifications@github.com wrote:

@tux-rampage https://github.com/tux-rampage requested your review on:

45 https://github.com/zendframework/zend-di/pull/45 Declare strict

types.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-di/pull/45#event-1972162911, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakHyCigVtotD0HPPwZ9z4KPpWfR5eks5uvx77gaJpZM4Ym6Pi .

[tux-rampage]

Definitly a goal. Should I add it in this PR or another one?

[Ocramius]

Another one, and we can apply this patch afterwards

On Sat, 17 Nov 2018, 10:02 Axel H. <notifications@github.com wrote:

Definitly a goal. Should I add it in this PR or another one?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-di/pull/45#issuecomment-439602029, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakKgKhmRC5fK2WsoSHBLxrDkBhTL7ks5uv9CwgaJpZM4Ym6Pi .

[Ocramius]

Now this can be rebased 👌

Can you try and check which level of PHPStan works in the test suite?

[tux-rampage]

Sure will look at it later, maybe tomorrow. Thanks.

[tux-rampage]

@Ocramius rebase is complete. I also changed the target branch from master to develop (idk why I didn't do that when opening this PR).