search

zendframework / zend-di

Di component from Zend Framework
BSD 3-Clause "New" or "Revised" License
46 stars 29 forks source link

Update zend-coding standard #47

Closed tux-rampage closed 4 years ago

tux-rampage commented 5 years ago

This PR aims to update the zend-coding standard to version 2

This is work in progress

Zend cs is currently in alpha. This PR should also help the contributors of zend-coding-standard to finalize it for the release.

Currently this just updates the dependencies and applies autofix to see the outcome.

TODO

tux-rampage commented 5 years ago

@webimpress I switched to dev-develop. Now the sniff fails. I guess due to active development:

> phpcbf -sp
ERROR: Referenced sniff "WebimpressCodingStandard.PHP.InstantiatingParenthesis" does not exist

Run "phpcbf --help" for usage information

Script phpcbf -sp handling the cs-fix event returned with error code 3
michalbundyra commented 5 years ago

@tux-rampage Yes, I removed that sniff from my library, because there is one in PHP_CodeSniffer. The change is in my PR https://github.com/zendframework/zend-coding-standard/pull/10

You can try to use that branch, as it contains the latest changes with more sniffs and then let us know if it is better for you. It contains fix for the comments in PHPDocs :)

michalbundyra commented 5 years ago

@tux-rampage would you like to try the latest alpha of Zend Coding Standard? https://github.com/zendframework/zend-coding-standard/releases/tag/2.0.0-alpha.3

tux-rampage commented 5 years ago

@tux-rampage would you like to try the latest alpha of Zend Coding Standard? https://github.com/zendframework/zend-coding-standard/releases/tag/2.0.0-alpha.3

Sure, but most likely not before next week. I'm quite busy at the moment.

michalbundyra commented 4 years ago

Closing now as we do not have yet ready zend-coding-standard and not sure if it will be ready before moving to Laminas.