zendframework / zend-di

Di component from Zend Framework
BSD 3-Clause "New" or "Revised" License
46 stars 29 forks source link

Feature: generated injector delegator #51

Closed michalbundyra closed 4 years ago

michalbundyra commented 5 years ago

In documentation we are suggesting to create in manually. I think we can have it in the library as it's generic code.

See: https://docs.zendframework.com/zend-di/cookbook/aot-guide/#5-add-aot-to-the-service-manager

Documentations needs update if it is going to be accepted.

michalbundyra commented 5 years ago

@tux-rampage

I also think it makes sense to add it to the ConfigProvider

I am not sure about it, what if someone already has it added there (the custom one) or if someone what to use another?

tux-rampage commented 5 years ago

@tux-rampage

I also think it makes sense to add it to the ConfigProvider

I am not sure about it, what if someone already has it added there (the custom one) or if someone what to use another?

Good point. Could you update the AoT guide?

michalbundyra commented 5 years ago

@tux-rampage

Could you update the AoT guide?

Docs is updated now.

tux-rampage commented 4 years ago

@michalbundyra As discussed in slack, I've addressed this one. Can you pleas re-check?

tux-rampage commented 4 years ago

Static analysis is failing: https://travis-ci.org/zendframework/zend-di/jobs/625613032#L425 This was introduced in #56