zendframework / zend-di

Di component from Zend Framework
BSD 3-Clause "New" or "Revised" License
46 stars 29 forks source link

Hotfix: PHP 7.4 compatibility #56

Closed waahhhh closed 4 years ago

waahhhh commented 4 years ago

Provide a narrative description of what you are trying to accomplish:


michalbundyra commented 4 years ago

@waahhhh Thanks for your contribution.

We can't accept this PR as it is - it contains BC Break (bump PHP version, by us considered as BC Break and can be released only with new major version) and Bugfix for PHP 7.4 compatibility.

Please provide bugfix separately - PR to master, and then other PR with bumped PHP version to develop. Thanks!

waahhhh commented 4 years ago

Removed version bump and changed phpunit/phpunit version from 8.5 to 7.5.

michalbundyra commented 4 years ago

Thanks, @waahhhh!

tux-rampage commented 4 years ago

This PR does not pass static analysis. Why didn't this PR trigger a travis build?

michalbundyra commented 4 years ago

@tux-rampage PR was to master, was merged as a hotfix.

tux-rampage commented 4 years ago

I see, thanks