Closed waahhhh closed 4 years ago
@waahhhh Thanks for your contribution.
We can't accept this PR as it is - it contains BC Break (bump PHP version, by us considered as BC Break and can be released only with new major version) and Bugfix for PHP 7.4 compatibility.
Please provide bugfix separately - PR to master, and then other PR with bumped PHP version to develop. Thanks!
Removed version bump and changed phpunit/phpunit
version from 8.5 to 7.5.
Thanks, @waahhhh!
This PR does not pass static analysis. Why didn't this PR trigger a travis build?
@tux-rampage PR was to master, was merged as a hotfix.
I see, thanks
Provide a narrative description of what you are trying to accomplish:
Noticed deprecated messages on PHP 7.4:
On PHP 7.4 CodeSniffer outputs the messages:
But that will be resolved by: https://github.com/zendframework/zend-di/pull/47
[x] Are you fixing a bug?
master
branch, and submit against that branch.CHANGELOG.md
entry for the fix.[ ] Are you creating a new feature?
develop
branch, and submit against that branch.CHANGELOG.md
entry for the new feature.[x] Is this related to quality assurance?
using error reporting on E_ALL for tests to
[ ] Is this related to documentation?