search

zendframework / zend-diactoros

PSR-7 HTTP Message implementation
BSD 3-Clause "New" or "Revised" License
1.55k stars 152 forks source link

Status code must be an integer following psr-7 #319

Closed snapshotpl closed 6 years ago

snapshotpl commented 6 years ago

@weierophinney can we keep this changes to v2.0?

weierophinney commented 6 years ago

can we keep this changes to v2.0?

I'd rather not.

Since the spec itself doesn't have explicit scalar type hints defined, what the constructors and various with*() methods accept is of less importance than what the accessors return. If we can massage the incoming data to the required type without data loss, we should.

If/when we do an update to the PSR-7 specification to add scalar type hints, we can revisit.

snapshotpl commented 6 years ago

That's explanation is enough for me. I will prepare changes

weierophinney commented 6 years ago

Thanks, @snapshotpl!