search

zendframework / zend-diactoros

PSR-7 HTTP Message implementation
BSD 3-Clause "New" or "Revised" License
1.56k stars 152 forks source link

Add integration tests #325

Closed Nyholm closed 6 years ago

Nyholm commented 6 years ago

I noticed that this library does not fully comply with psr7.

I’ve added integration test to show where it is failing.

(I’m at the airport atm, will complete this PR later)

Nyholm commented 6 years ago

Oh. It looks like this PR is working as expected. There are just some cs fixes needed

Ocramius commented 6 years ago

Picking this up for checking while I'm on travel tomorrow :+1:

weierophinney commented 6 years ago

@Nyholm I've pushed the changes I requested, and am now working on fixes for the flagged errors.

Nyholm commented 6 years ago

Awesome. Thanks!

Nyholm commented 6 years ago

You are great. Thank you!