Segfault in PHP 7.3.0 when instantiating HtmlResponse in Built-in Web Server

mnavarrocarter commented 5 years ago

[x] This is not a question. (Questions should be asked on chat (Signup here) or our forums.)
[x] I was not able to find an open or closed issue matching what I'm seeing.

I'm developing a tiny REST Api using PHP. For HTTP I've decided to go with Diactoros. However, when I'm developing with PHP's Built-in web server, I get a segmentation fault when instantiating HtmlResponse. You can replicate it just by doing:

Steps to Reproduce

<?php

require_once __DIR__.'/../vendor/autoload.php';

$response = new \Zend\Diactoros\Response\HtmlResponse('Testing');

Then, run that file using php server: php -S 0.0.0.0:8000 -t .

Extra Research

Before you say that this is a PHP issue, I executed the code of what Diactoros does under the hood, and I didn't ran into any issues. For instance:

$string = 'Dummy string';

$stream = fopen('php://temp', 'wb+');
fwrite($stream, $string);
fseek($stream, 0);

if (ftell($stream) === 0) {
    echo 'Code works!'.PHP_EOL;
} else {
    echo 'Code does not work!'.PHP_EOL;
}

fclose($stream);

My guess is that is something stream related, but I cannot figure out what. It is also weird that only happens when using the web server, and not if I run the script using the cli.

malukenho commented 5 years ago

@mnavarrocarter Hello! Can you check your php version? I tried php -S 0.0.0.0:8000 -t . and it worked fine on version 7.2 and 7.3. It's very common to have different php versions running on CLI and web server, are you sure that isn't the problem?

michalbundyra commented 5 years ago

@malukenho as the autor says in the subject - PHP 7.3.0 :) I'm just about to check it

malukenho commented 5 years ago

@webimpress yes. I just checked on 7.3 as stated above.

PHP 7.3.0 (cli) (built: Dec  7 2018 11:00:11) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0, Copyright (c) 1999-2018, by Zend Technologies

michalbundyra commented 5 years ago

@malukenho Ah! You have edited your original comment :)

But yes - it works for me as well on PHP 7.3.0:

PHP 7.3.0-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec  6 2018 20:24:55) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

mnavarrocarter commented 5 years ago

This is my php version:

PHP 7.3.0-2 (cli) (built: Dec 17 2018 09:51:53) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-2, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

Also, here is php -i output.

php -i output

Maybe I can build a docker container that replicates the issue. Could that be useful?

weierophinney commented 5 years ago

Maybe I can build a docker container that replicates the issue. Could that be useful?

Yes, because we've had two people indicate they cannot reproduce.

mnavarrocarter commented 5 years ago

Here's the dockerfile. I was able to reproduce:

FROM debian:buster

RUN apt update && apt install php-common php-mysql php-mbstring php-fpm php-xdebug php-zip php-json php-xml wget -y

WORKDIR /root

RUN wget https://github.com/composer/composer/releases/download/1.8.0/composer.phar

RUN php composer.phar require zendframework/zend-diactoros

RUN echo "<?php require_once 'vendor/autoload.php'; new \Zend\Diactoros\Response\HtmlResponse('Test');" > index.php

EXPOSE 8000

CMD php -S 0.0.0.0:8000 -t .

Then: docker build .

Once built: docker run -p <localport>:8000 <imageid>

weierophinney commented 5 years ago

No; I just edited your comment to fold the contents of the php -i output so that readers don't need to scroll through the entire thing to read further comments.

On Jan 5, 2019 7:58 PM, "bluebaroncanada" notifications@github.com wrote:

Is this solved now?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-diactoros/issues/343#issuecomment-451708448, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlVySTXMnki7BxR838Z7BUEVGtFvTlks5vAVg9gaJpZM4ZaQKS .

anVlad11 commented 5 years ago

Got segfault on 7.3 too, traced it to this part:

https://github.com/zendframework/zend-diactoros/blob/d966a8a5237f3e317580a6e1cd13be19e1ed7d79/src/Stream.php#L178-L204

When emitting response, $this->seek is called with one argument, but $whence somehow becomes NULL (despite SEEK_SET being 0). fseek() expects int as third argument and throws an exception.

PHP 7.2, same config - everything works fine.

anvlad11@server:~$ php7.3 -v
PHP 7.3.0-2+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec 17 2018 09:22:47) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-2+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

anvlad11@server:~$ php7.2 -v
PHP 7.2.13-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec  7 2018 08:07:36) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.13-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.6.1, Copyright (c) 2002-2018, by Derick Rethans

mnavarrocarter commented 5 years ago

Thanks for reproducing @anVlad11 ! Now I'm more inclined to believe this is a bug on Php.

weierophinney commented 5 years ago

I'm thinking it's either a bug in PHP, or in the interaction of the output stream emitted by the Docker container.

I can take reproduce using the container above. However, when I use my local PHP 7.3.0 binary and follow the same steps (composer install + php index.php), no segmentation fault occurs. Considering no rewind() or seek() operations occur when first creating the HtmlResponse, nor when destructing it (or its related stream), coupled with the fact that this is abnormal usage (creating the instance and doing nothing with it), I have no idea how or where that seek() call could even happen. As such, I'm going to chalk it up as an edge case for now, and close the issue. If you can find a way to reliably reproduce it with a standard binary, we can re-open.

anVlad11 commented 5 years ago

I've been able to reproduce this using php7.3-fpm with zend-expressive-skeleton application without any modifications to it or php configuration. I could provide any server configuration information, if needed.

mnavarrocarter commented 5 years ago

Thanks @weierophinney. It may be Docker. I'm doing some testing on my own. :)

zendframework / zend-diactoros

Segfault in PHP 7.3.0 when instantiating HtmlResponse in Built-in Web Server #343

Steps to Reproduce

Extra Research