Bug fix: Uncaught TypeError: Return value of Zend\\Diactoros\\Uri::fi…

zendframework / zend-diactoros

PSR-7 HTTP Message implementation

BSD 3-Clause "New" or "Revised" License

1.56k stars 152 forks source link

Closed ghost closed 5 years ago

ghost commented 5 years ago

…lterQueryOrFragment() must be of the type string, null returned

Provide a narrative description of what you are trying to accomplish:

[x] Are you fixing a bug?
- [x] Detail how the bug is invoked currently. 　#218
- [x] Detail the original, incorrect behavior. 　#357

michalbundyra commented 5 years ago

@Ocramius @soru1001

I think it is invalid. preg_replace_callback returns null on error only: https://www.php.net/preg_replace_callback
Even if it would be valid it's a BC Break...