search

zendframework / zend-escaper

Escaper component from Zend Framework
BSD 3-Clause "New" or "Revised" License
331 stars 30 forks source link

Fix encoding of supplementary characters #3

Closed zerocrates closed 8 years ago

zerocrates commented 9 years ago

Fixes #2.

This PR adds test for supplementary characters (using the first supplementary character, U+10000, as an example) for escapeHtmlAttr, escapeCss, and escapeJs. The tests all fail on the current master branch and pass with the included changes.

mwillbanks commented 9 years ago

@padraic could you please review this change?

samsonasik commented 9 years ago

ping @padraic

samsonasik commented 9 years ago

ping @padraic

mwillbanks commented 9 years ago

ping @weierophinney @Ocramius - can you provide this a review

marc-mabe commented 8 years ago

For me as far as I know this fix looks fine. All current tests passed as well as the new ones which matches the result for the given test code point U+10000 listed here http://www.fileformat.info/info/unicode/char/10000/index.htm

padraic commented 8 years ago

Apologies for the delays all. Looks good here.

samsonasik commented 8 years ago

merge, then?

zerocrates commented 8 years ago

Any possibility of a merge before this celebrates its first birthday?

weierophinney commented 8 years ago

Thanks, @zerocrates - released with 2.5.2.