Previous response bodies in $response->getBody()->getContent()

[wshafer]

• [X] I was not able to find an open or closed issue matching what I'm seeing.
• [X] This is not a question. (Questions should be asked on slack (Signup for Slack here) or our forums.)

Provide a narrative description of what you are trying to accomplish.

$this->responsePrototype is not building a new response object for each response. So using Swoole or PHPReact results in previous responses bleeding into each other.

Code to reproduce the issue

$response = $this-handle($request);
$response = $this-handle($request);
$response->getBody()->getContent();

Expected results

Only one response per request

Actual results

Mutiple response bodies per request

[michalbundyra]

@wshafer I think it's resolved with the lates release (5 hours ago). Can you confirm what version are you using?

/cc @weierophinney

[wshafer]

Nope. This is still pulling the Response from the container and not a new one for each response. So if a response has already been built, the previous response will be returned. Even though using a with{function}() returns a clone of the response, the initial stream is still used for each clone, so when you write() it just goes to the end of the existing stream.

[weierophinney]

@webimpress It's not resolved. The ResponsePrototypeTrait from zend-expressive-authentication pulls the ResponseInterface service, and returns it directly; if none is available, it returns a zend-diactoros response instance.

In the latter case, it's fine; it's returning a discrete response instance. However, in the case of the ResponseInterface service being present, it needs to read:

return $container->has(ResponseInterface::class)
    ? ($container->get(ResponseInterface::class)()
    : new Response();

That said, I'd argue that these adapters and zend-expressive-authentication should be composing a response factory instead of the prototype. That will also allow us to stop having the soft requirement on zend-diactoros, as it will be up to the consumer to supply the ResponseInterface service.

So, we need:

• To update the ResponsePrototypeTrait to read:

  return $container->has(ResponseInterface::class)
    ? $container->get(ResponseInterface::class)
    : function () {
        return new Response();
    };

• Update each adapter package where a response prototype is currently composed to instead compose a response factory.

[weierophinney]

Actually... let's go with the following:

• Remove the ResponsePrototypeTrait entirely.
• Each class should compose a response factory instead of a prototype. When they accept the factory, they should wrap it in a closure that adds a return type hint of ResponseInterface to ensure return type safety.

[weierophinney]

Fixed with #17.