Use iterable instead of array?

zendframework / zend-expressive-authentication

Authentication middleware for Expressive and PSR-7 applications

BSD 3-Clause "New" or "Revised" License

21 stars 15 forks source link

Use iterable instead of array? #26

Closed internalsystemerror closed 6 years ago

internalsystemerror commented 6 years ago

https://github.com/zendframework/zend-expressive-authentication/blob/2fea5529d78cddc26921e46e87ea886ccb8cc7d1/src/UserInterface.php#L24

I'm looking to implement RBAC and DoctrineORM with this, changing the return type to iterable instead of array would allow the use of a Collection (of RoleInterface's). 7.1 is the minimum version of this component.

Any problems with this approach? I wanted to ask before just submitting a PR.

geerteltink commented 6 years ago

Works for me.

ezimuel commented 6 years ago

Fixed in #27