Not supporting domain, secure neither cookie http only flags

zendframework / zend-expressive-session-ext

PHP ext-session persistence adapter for zend-expressive-session.

BSD 3-Clause "New" or "Revised" License

12 stars 9 forks source link

Closed smalot closed 5 years ago

smalot commented 5 years ago

When using php.ini with such values:

session.cookie_domain = 'test.local'
session.cookie_httponly = 1
session.cookie_secure = 1

In such case, set-cookie should contain Domain, Secure and HttpOnly:

Set-Cookie: PHPSESSID=g6WMHd[...]fcZ; Path=/; Domain=test.local; Secure; HttpOnly

weierophinney commented 5 years ago

Could you send a pull request with the requested change, please?

harikt commented 5 years ago

@weierophinney I noticed @smalot send PR to his own branch https://github.com/smalot/zend-expressive-session-ext/pull/2 . May be you could just pull and merge ?

weierophinney commented 5 years ago

I've created #31, using the commits from smalot/zend-expressive-session-ext#2.