zendframework / zend-expressive-skeleton

Begin developing PSR-7 middleware applications in seconds!
BSD 3-Clause "New" or "Revised" License
136 stars 90 forks source link

Develop branch #133

Closed harikt closed 7 years ago

harikt commented 7 years ago

I have cloned the repo and did a composer install on the develop branch.

> ExpressiveInstaller\OptionalPackages::install
Setting up optional packages
Setup data and cache dir
Removing installer development dependencies

  What type of installation would you like?
  [1] Minimal (no default middleware, templates, or assets; configuration only)
  [2] Flat (flat source code structure; default selection)
  [3] Modular (modular source code structure; recommended)
  Make your selection (2): 2
  - Copying src/App/ConfigProvider.php

  Which container do you want to use for dependency injection?
  [1] Aura.Di
  [2] Pimple
  [3] Zend ServiceManager
  Make your selection or type a composer package name and version (Zend ServiceManager): 1
  - Adding package aura/di (^3.0)
  - Copying config/container.php
  - Copying config/ExpressiveAuraConfig.php
  - Copying config/ExpressiveAuraDelegatorFactory.php

  Which router do you want to use?
  [1] Aura.Router
  [2] FastRoute
  [3] Zend Router
  Make your selection or type a composer package name and version (FastRoute): 1
  - Adding package zendframework/zend-expressive-aurarouter (^2.0)
  - Copying config/routes.php
  - Copying config/autoload/router.global.php

  Which template engine do you want to use?
  [1] Plates
  [2] Twig
  [3] Zend View installs Zend ServiceManager
  [n] None of the above
  Make your selection or type a composer package name and version (n): 2
  - Adding package zendframework/zend-expressive-twigrenderer (^1.2.1)
  - Copying config/autoload/templates.global.php
  - Copying templates/error/404.html.twig
  - Copying templates/error/error.html.twig
  - Copying templates/layout/default.html.twig
  - Copying templates/app/home-page.html.twig

  Which error handler do you want to use during development?
  [1] Whoops
  [n] None of the above
  Make your selection or type a composer package name and version (Whoops): 1
  - Adding package filp/whoops (^2.0)
Remove installer
Removing composer.lock from .gitignore
Removing Expressive installer classes, configuration, tests and docs
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 35 installs, 0 updates, 0 removals
  - Installing zendframework/zend-expressive-zendrouter (2.0.0) Downloading: 100%         
  - Installing zendframework/zend-expressive-helpers (3.0.1) Downloading: 100%         
  - Installing league/plates (3.3.0) Loading from cache
  - Installing zendframework/zend-expressive-platesrenderer (1.2.0) Loading from cache
  - Installing twig/twig (v1.31.0) Loading from cache
  - Installing zendframework/zend-expressive-twigrenderer (1.2.1) Loading from cache
  - Installing zendframework/zend-eventmanager (3.1.0) Loading from cache
  - Installing zendframework/zend-view (2.8.1) Loading from cache
  - Installing zendframework/zend-expressive-zendviewrenderer (1.2.1) Downloading: 100%         
  - Installing zfcampus/zf-development-mode (3.1.0) Downloading: 100%         
  - Installing filp/whoops (2.1.6) Loading from cache
  - Installing sebastian/version (2.0.1) Loading from cache
  - Installing sebastian/resource-operations (1.0.0) Loading from cache
  - Installing sebastian/recursion-context (2.0.0) Loading from cache
  - Installing sebastian/object-enumerator (2.0.1) Loading from cache
  - Installing sebastian/global-state (1.1.1) Loading from cache
  - Installing sebastian/exporter (2.0.0) Loading from cache
  - Installing sebastian/environment (2.0.0) Loading from cache
  - Installing sebastian/diff (1.4.1) Loading from cache
  - Installing sebastian/comparator (1.2.4) Loading from cache
  - Installing doctrine/instantiator (1.0.5) Loading from cache
  - Installing phpunit/php-text-template (1.2.1) Loading from cache
  - Installing phpunit/phpunit-mock-objects (4.0.0) Loading from cache
  - Installing phpunit/php-timer (1.0.8) Loading from cache
  - Installing phpunit/php-file-iterator (1.4.2) Loading from cache
  - Installing sebastian/code-unit-reverse-lookup (1.0.0) Loading from cache
  - Installing phpunit/php-token-stream (1.4.9) Loading from cache
  - Installing phpunit/php-code-coverage (5.0.0) Loading from cache
  - Installing webmozart/assert (1.2.0) Loading from cache
  - Installing phpdocumentor/reflection-common (1.0) Loading from cache
  - Installing phpdocumentor/type-resolver (0.2.1) Loading from cache
  - Installing phpdocumentor/reflection-docblock (3.1.1) Loading from cache
  - Installing phpspec/prophecy (v1.6.2) Loading from cache
  - Installing myclabs/deep-copy (1.6.0) Loading from cache
  - Installing phpunit/phpunit (6.0.7) Downloading: 100%         
zendframework/zend-expressive-helpers suggests installing mouf/pimple-interop (^1.0 to use Pimple for dependency injection)
zendframework/zend-expressive-platesrenderer suggests installing mouf/pimple-interop (^1.0 to use Pimple for dependency injection)
zendframework/zend-expressive-twigrenderer suggests installing mouf/pimple-interop (^1.0 to use Pimple for dependency injection)
zendframework/zend-view suggests installing zendframework/zend-authentication (Zend\Authentication component)
zendframework/zend-view suggests installing zendframework/zend-feed (Zend\Feed component)
zendframework/zend-view suggests installing zendframework/zend-filter (Zend\Filter component)
zendframework/zend-view suggests installing zendframework/zend-i18n (Zend\I18n component)
zendframework/zend-view suggests installing zendframework/zend-json (Zend\Json component)
zendframework/zend-view suggests installing zendframework/zend-mvc (Zend\Mvc component)
zendframework/zend-view suggests installing zendframework/zend-navigation (Zend\Navigation component)
zendframework/zend-view suggests installing zendframework/zend-paginator (Zend\Paginator component)
zendframework/zend-view suggests installing zendframework/zend-permissions-acl (Zend\Permissions\Acl component)
filp/whoops suggests installing symfony/var-dumper (Pretty print complex values better with var-dumper available)
filp/whoops suggests installing whoops/soap (Formats errors as SOAP responses)
sebastian/global-state suggests installing ext-uopz (*)
phpunit/phpunit-mock-objects suggests installing ext-soap (*)
phpunit/phpunit suggests installing phpunit/php-invoker (^1.1)
phpunit/phpunit suggests installing ext-xdebug (*)
Writing lock file
Generating autoload files

As you can see even if I have not selected zendframework/zend-view or plates it installs everything.

I was looking at

$ composer why zendframework/zend-view
zendframework/zend-expressive-zendviewrenderer  1.2.1  requires  zendframework/zend-view (^2.8.1)  

$ composer why zendframework/zend-expressive-zendviewrenderer
There is no installed package depending on "zendframework/zend-expressive-zendviewrenderer"
geerteltink commented 7 years ago

I have replicated the exact same issue. I checked the code and it's correct. It's just the way composer works and it's installing the dev dependencies. If you run composer update you should see that it's removing about 30 packages, depending your configuration.

The only 2 ways I could install it as it intended is like this:

  1. composer create-project zendframework/zend-expressive-skeleton expressive-test "2.0.x-dev"
  2. Using the method described here. This way you can test local branches.