Closed elie29 closed 5 years ago
@elie29
I think the namespace Zend
is not correct here, because it is not an official Zend Framework component / package.
It creates also irritations, because Zend Framework already has a component with the name "zend-di" and the namespace Zend\Di
.
@froschdesign thank you for this feedback. The namespace became Zend\PHPDI as suggested by @xtreamwayz it is a mix of Zend and PHPDI. It should create no conflict with Zend DI.
@elie29
The namespace became Zend\PHPDI as suggested by…
I'm sorry, then @xtreamwayz was wrong here.
It should create no conflict with Zend DI.
Are you sure? 😉
The namespace became Zend\PHPDI as suggested by @xtreamwayz it is a mix of Zend and PHPDI. It should create no conflict with Zend DI.
It was a suggestion to prevent confusion and conflict with the original Zend\DI component. I don't know about the legal stuff etc. That's my bad to include Zend\PHPDI in the suggestions. I also suggested other namespaces. For things I create myself I use Xtreamwayz
as a namespace to avoid conflicts with other packages.
@xtreamwayz
I don't know about the legal stuff…
I’m also not a lawyer or jurist, but I think the licence is clearly at this point:
Neither the name of Zend or Rogue Wave Software, nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
https://framework.zend.com/license
But the bigger problem is the name and the namespace, because everyone thinks this is an official ZF component.
Neither the name of Zend or Rogue Wave Software, nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
Oh, I'm protected as well :D
@froschdesign @xtreamwayz I don't mind to change the namespace and then update the PR. @weierophinney Is Zend\PHPDI\Config violates Zend Framework licence ?
@weierophinney Is Zend\PHPDI\Config violates Zend Framework licence ?
It would be one thing if we intended to bring the component into the zendframework organization, but it's another thing entirely if it's a 3rd-party plugin. While we provided a number of integrations out-of-the-box (e.g., Aura.Di, Pimple), these were mainly to serve as a demonstration for developers to create, develop, and distribute their own integrations, as any integration we provide we then need to maintain.
As such, it would be better if you were to use your own namespace. As @xtreamwayz noted, he uses his username as a namespace when writing his own integrations. I have the Phly
namespace for those I write. It's not uncommon, and it helps developers identify where the code originates. Using Zend
as the top-level namespace for code that is not under the zendframework
organization is misleading.
@weierophinney thank you for your explanation, I am making the change in order to update the PR.
@xtreamwayz suggested a namespace change for zend-di-config #31.
Starting from v4, the namespace will be Elie\PHPDI\Config instead of Zend\DI\Config.
A migration document from v3 to v4 has been created here