search

zendframework / zend-expressive-skeleton

Begin developing PSR-7 middleware applications in seconds!
BSD 3-Clause "New" or "Revised" License
136 stars 90 forks source link

ocramius/proxy-manager needed? #99

Closed Koopzington closed 8 years ago

Koopzington commented 8 years ago

Is there a reason why ocramius/proxy-manager is in require-dev? The tests are running fine without it.

Ocramius commented 8 years ago

Not required, indeed, but needed for using lazy services.

Can you look up who added it, and why?

Koopzington commented 8 years ago

The package was added by @xtreamwayz in This commit. Downloaded a Tarball of that version and searched for anything mentioning "Proxy" and found nothing but the package name in the composer.json and the ExpressiveInstaller config.php I'm not saying Lazy Services are bad. If this package is only included to encourage using them, i'm all in, but it feels like the skeleton has even more dependencies than the zend-mvc skeleton....

geerteltink commented 8 years ago

I added this during development. Most likely because I copied dependencies from somewhere else. As far as I know the proxy-manager is nowhere used and could be used.

but it feels like the skeleton has even more dependencies than the zend-mvc skeleton....

I'm not sure how you get that feeling. It has only 5 dependencies and they all are being used and speak for their self:

    "php": "^5.5 || ^7.0",
    "roave/security-advisories": "dev-master",
    "zendframework/zend-expressive": "^1.0",
    "zendframework/zend-expressive-helpers": "^2.0",
    "zendframework/zend-stdlib": "^2.7 || ^3.0"

If you are referring to all the other dev-requirements, I've added those because they were used in tests or I needed them for code completion. However the code has changed during development so I'm not sure which are obsolete now.

geerteltink commented 8 years ago

Found them. Have a look in the config sources.

geerteltink commented 8 years ago

And the proxy manager is installed by default as well: https://github.com/zendframework/zend-expressive-skeleton/blob/master/src/ExpressiveInstaller/config.php#L109

Koopzington commented 8 years ago

The skeleton itself might not have that many dependencies but the dependencies themselves have several others. But there's nothing we can do about that. Anyways... would it be okay if i create a PR to remove that particular line you posted (which would let us get rid off zendframework/zend-code, zendframework/zend-eventmanager and ocramius/package-versions).

While we're on it: I've discovered that even if you decide not to use filp/whoops as ErrorHandler, it get's added to require-dev by this piece of code. I guess making that require-dev array empty should do the trick.