Add tests for duplicate values for addDefaultParam method

zendframework / zend-expressive-twigrenderer

Twig integration for Expressive

BSD 3-Clause "New" or "Revised" License

25 stars 14 forks source link

Closed geerteltink closed 7 years ago

geerteltink commented 7 years ago

This PR doesn't fix anything but it adds tests for duplicate values when passing arrays with the addDefaultParam() method, as mentioned in #21.

The fix should be applied to DefaultParamsTrait in zend-expressive-template.

EDIT: Fixed with zendframework/zend-expressive-template#10, which also might make this PR obsolete. Although extra tests are always good.

weierophinney commented 7 years ago

Closing, as zend-expressive-template 1.0.4 now contains the changes necessary to make these pass, and the tests are present in that repository.