zendframework / zend-expressive-twigrenderer

Twig integration for Expressive
BSD 3-Clause "New" or "Revised" License
25 stars 14 forks source link

Refactor the default Twig extension into its own factory #41

Closed geerteltink closed 6 years ago

geerteltink commented 6 years ago

Why did I do this?

https://github.com/zendframework/zend-expressive-twigrenderer/blob/8de4ced7e987c299f8136bb094f27393a6407999/src/TwigEnvironmentFactory.php#L106-L115

This way you can't override the default extension and it's registered functions. Moving this into its own factory and use the default twig -> extensions config key would be a better approach.

weierophinney commented 6 years ago

Fixed in #43