search

zendframework / zend-expressive-twigrenderer

Twig integration for Expressive
BSD 3-Clause "New" or "Revised" License
25 stars 14 forks source link

Use `auto_reload` option from `twig` section in config #53

Closed 0nua closed 5 years ago

0nua commented 5 years ago

We need also add unit test and update configuration example in README.md.

done

michalbundyra commented 5 years ago

@0nua I would say we need one more test - when auto_reload is not set, to check it has the same value as debug.

EDIT: and maybe if we have debug = true, and auto_reload = false.

0nua commented 5 years ago

@webimpress , I have added new one test, and we have 3 tests for auto_reload option:

  1. testUsesDebugConfiguration for configuration: debug = true and auto_reload is not set
  2. testAutoReloadIgnoreDebugConfiguration for debug = true and auto_reload = false
  3. testAutoReloadUsesConfiguration for debug = false and auto_reload = true
michalbundyra commented 5 years ago

@0nua Have you pushed everything? I can see just two tests... Where is the 3rd one?

0nua commented 5 years ago

@webimpress here. It is old test, but it checks debug with auto_reload value

weierophinney commented 5 years ago

Thanks, @0nua; merged to develop for release with 2.3.0.

0nua commented 5 years ago

Thanks, @weierophinney