zendframework / zend-expressive-zendviewrenderer

zend-view PhpRenderer integration for Expressive
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

added files to be ignored during export #34

Closed gabbydgab closed 7 years ago

gabbydgab commented 7 years ago

Additional files to be ignored during export:

Ocramius commented 7 years ago

@gabbydgab can you rebase? I changed the target to develop on purpose.

gabbydgab commented 7 years ago

@Ocramius updated from upstream develop

Ocramius commented 7 years ago

Eh, no, that's a merge :-\

gabbydgab commented 7 years ago

@Ocramius sorry about that.. fixed rebase.. thanks

geerteltink commented 7 years ago

Why excluding important documents (CONDUCT, CONTRIBUTING, README, CHANGELOG) from tarballs?

Same in zendframework/zend-expressive-zendrouter#17

gabbydgab commented 7 years ago

@xtreamwayz

For consumer - may be irrelevant (except for change logs; if affected by X.Y.Z release) For contributor - needed as guide.

If they experience BC breaks/bugs during updates, most of them look at the package repository and not in the vendor folder.

IMO, it will be much effective if release information will be added on composer.json similar to suggestions because it explicitly explains the updated version of the dependency - maybe new composer feature? :thinking:

"changes": {
    "added": ["new features"],
    "deprecated": ["notices"],
    "removed": ["removed"],
    "fixes": ["bc fixes or not"]
}

Thoughts?

geerteltink commented 7 years ago

Have you seen some of the changelogs? Besides issues with formatting, I don't think you want all that info in composer.json.

gabbydgab commented 7 years ago

Yes, but probably will just add a summary link pointing to those non-critical impacts. ONLY critical impacts like BC breaks will be added, others will be a summary link.

weierophinney commented 7 years ago

I'll merge, but with the following changes to no longer exclude the following files within .gitattributes:

These are user-facing files, and contain information that users may want/need to reference. While they may end up going to the repository website, this puts information at their fingertips immediately, and without requiring a network connection.

weierophinney commented 7 years ago

Thanks, @gabbydgab