search

zendframework / zend-expressive-zendviewrenderer

zend-view PhpRenderer integration for Expressive
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Use PSR-11 Container Interface #37

Closed geerteltink closed 6 years ago

geerteltink commented 7 years ago

container-interop can't be removed completely... ZendViewRendererFactoryTest has tests for Zend\ServiceManager\AbstractPluginManager, which is not updated yet.

michaelmoussa commented 7 years ago

@xtreamwayz this looks good (so far) but I suggest waiting on merging this until container-interop can be removed completely. The partial changes are already a BC break, and removing container-interop entirely later would be another BC break. Might as well do it all in one shot.

There are quite a number of references to it in zendframework/zend-servicemanager which likely tie in to other ZF components, but as long as it gets a major version bump, we shouldn't need to update the other components right away.

michaelmoussa commented 7 years ago

I went ahead and submitted a PR to both zendframework/zend-servicemanager and zendframework/zend-eventmanager for interop -> PSR-11. Maybe we can end up removing interop from this PR entirely like you were able to do for the other two renderer repositories.

mwillbanks commented 6 years ago

At this point this is starting to look really good. I do think we need to support PSR-11 properly, there are some other comments that might be necessary to look at prior. My approval is strictly on the code and the implements.

weierophinney commented 6 years ago

Thanks, @xtreamwayz!