Default params now passed to child models. Fixes #57. - Githubissues

zendframework / zend-expressive-zendviewrenderer

zend-view PhpRenderer integration for Expressive

BSD 3-Clause "New" or "Revised" License

11 stars 12 forks source link

Default params now passed to child models. Fixes #57. #58

Closed samuelnogueira closed 6 years ago

samuelnogueira commented 6 years ago

Pass default parameters to child view models:

[x] Are you fixing a bug?
- [x] Detail how the bug is invoked currently. Detailed in #57
- [x] Detail the original, incorrect behavior. Detailed in #57
- [x] Detail the new, expected behavior. Default parameters for the child template and all templates are passed to child view model
- [x] Add a regression test that demonstrates the bug, and proves the fix. See \ZendTest\Expressive\ZendView\ZendViewRendererTest::testRenderChildWithDefaultParameter
- [ ] Add a CHANGELOG.md entry for the fix. (should I?)
[x] Is this related to quality assurance? I think not.
[x] Is this related to documentation? No.

weierophinney commented 6 years ago

Thanks, @samuelnogueira!