search

zendframework / zend-expressive-zendviewrenderer

zend-view PhpRenderer integration for Expressive
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

Fixed missing root using layout viewhelper #62

Closed fduarte42 closed 5 years ago

fduarte42 commented 5 years ago

Fixed bug mentioned here: zendframework/zend-expressive-skeleton#68

fduarte42 commented 5 years ago

Everything should be clean now. Please let me know if it is ok. We need this fix for a deployment.

Thanks in advance.

froschdesign commented 5 years ago

@fduarte42

We need this fix for a deployment.

Then use your own fork in the meantime: https://getcomposer.org/doc/04-schema.md#repositories

fduarte42 commented 5 years ago

ok, we can use this for workaround now. But just out of curiosity: How long does such a review take? No pressure though. Really.

geerteltink commented 5 years ago

ok, we can use this for workaround now. But just out of curiosity: How long does such a review take? No pressure though. Really.

Depends on the PR. I don't use zend-view myself so I won't merge this as I have no clue what it does and if this would be a good solution. You would have to wait for someone else and since it's Friday it will probably be early next week.

weierophinney commented 5 years ago

Thanks, @fduarte42!