search

zendframework / zend-expressive

PSR-15 middleware in minutes!
BSD 3-Clause "New" or "Revised" License
711 stars 197 forks source link

marshalLazyMiddlewareService() incompatible with zend-stratigility 1.3 and http-interop style middleware #389

Closed moderndeveloperllc closed 7 years ago

moderndeveloperllc commented 7 years ago

zend-stratigility 1.3 just dropped and includes code to dispatch middleware that conforms to the http-interop (soon to be PSR-15 I guess) ServerMiddlewareInterface standard. The problem is that Zend\Expressive\MarshalMiddlewareTrait::marshalLazyMiddlewareService() wraps middleware in a Closure, which therefore bypasses the stratigility Dispatch code.

Yes, that code has been deprecated and will be removed in zend-stratigility 2.0, but this should still be resolved as many will stick with 1.3 and gradually migrate to the http-interop middleware style over time. zend-stratigility 2.0 will require http-interop style middleware.

weierophinney commented 7 years ago

This planned, and I will be staying work on it shortly:

moderndeveloperllc commented 7 years ago

@weierophinney Feel free to close, or leave up if you want others to see.

weierophinney commented 7 years ago

396 will fix this; closing this for now, as the logic is complete, and will be merged to develop soon in preparation for a 1.1 release.