zendframework / zend-expressive

PSR-15 middleware in minutes!
BSD 3-Clause "New" or "Revised" License
711 stars 197 forks source link

Invalid dependencies in ConfigProvider #548

Closed geerteltink closed 6 years ago

geerteltink commented 6 years ago

There are some nonexisting classes in the ConfigProvider. Are they there for a reason?

https://github.com/zendframework/zend-expressive/blob/3c365f1c4aec01b5ce1b55477d5f70f405ed503d/src/ConfigProvider.php#L37-L39

https://github.com/zendframework/zend-expressive/blob/3c365f1c4aec01b5ce1b55477d5f70f405ed503d/src/ConfigProvider.php#L43

https://github.com/zendframework/zend-expressive/blob/3c365f1c4aec01b5ce1b55477d5f70f405ed503d/src/ConfigProvider.php#L55-L56

michalbundyra commented 6 years ago

I believe some of them are there only to make migration (from v2 to v3) easier. We used these classes before, and now we define aliases only. For example see: https://github.com/zendframework/zend-expressive/blob/master/docs/book/features/container/factories.md (this is at least about Delegate\DefaultDelegate)

weierophinney commented 6 years ago

I can vouch for each, and I'll explain them.