search

zendframework / zend-feed

Feed component from Zend Framework
BSD 3-Clause "New" or "Revised" License
166 stars 42 forks source link

added title in feed discovery as per document #63

Closed rajjanorkar closed 6 years ago

rajjanorkar commented 7 years ago

added title in feed discovery as per document https://docs.zendframework.com/zend-feed/find-feeds/

froschdesign commented 7 years ago

@rajjanorkar If you create a new feature or find a bug, please add always an unit test. Thanks!

Btw. good catch!

rajjanorkar commented 7 years ago

Hi @froschdesign I am really not that good in writing test, and for this scenario i tried but not getting idea.

I improved it to used nodeValue than title attribute not all links have title.

edit : nodeValue does not make sense here as we are only searching for link tag so we have title attribute for that tag.

I have added test created another pull request. (i am just editing here on github so was not able to combine both in one pull request (pull request 64)

Thank you

froschdesign commented 7 years ago

@rajjanorkar Add the unit test here.

rajjanorkar commented 7 years ago

@froschdesign added

rajjanorkar commented 7 years ago

@froschdesign could you please merge ?

froschdesign commented 7 years ago

@rajjanorkar The workflow is not completed: a review is still needed.

rajjanorkar commented 6 years ago

I think the process is so slow here...

Ocramius commented 6 years ago

Welcome to OSS 😑

rajjanorkar commented 6 years ago

Thanks @Ocramius

weierophinney commented 6 years ago

Thanks, @rajjanorkar