search

zendframework / zend-filter

Filter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
68 stars 35 forks source link

str-function instead of preg-function #2

Closed freax closed 9 years ago

freax commented 9 years ago

str_replace will be much faster

Maks3w commented 9 years ago

@freax Can you provide a benchmark?

manuakasam commented 9 years ago

str_replace is faster across the board, assuming I didn't completely f*** up the timing logic ;)

http://3v4l.org/AUfut

Maks3w notifications@github.com schrieb am Mo., 15. Juni 2015 um 12:34 Uhr:

@freax https://github.com/freax Can you provide a benchmark?

— Reply to this email directly or view it on GitHub https://github.com/zendframework/zend-filter/pull/2#issuecomment-112014428 .

weierophinney commented 9 years ago

@Maks3w Please merge to develop as well.

Maks3w commented 9 years ago

It's merged, bug GH does not display the commit in the PR