Unique name on Windows need more_entropy

zendframework / zend-filter

Filter component from Zend Framework

BSD 3-Clause "New" or "Revised" License

68 stars 35 forks source link

Unique name on Windows need more_entropy #3

Closed MatyCZ closed 7 years ago

MatyCZ commented 9 years ago

If you upload more files in 1s on Windows, uniqid will be the same.

weierophinney commented 8 years ago

Before we can review this:

Please provide unit tests for the functionality.
Existing tests break because of the changes. They will either need to be updated, or the functionality introduced reviewed to ensure no breakage occurs.

Additionally, can you point to a bug report on the PHP bug tracker that indicates this behavior? I've used uniqid() for years, and never seen it generate the same hash within the same second; how many files are we talking about?

Ocramius commented 8 years ago

@weierophinney can't remember why I was even using windows, but yeah, uniqid() is not unique on windows (within the same millisecond) :-(