search

zendframework / zend-filter

Filter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
68 stars 35 forks source link

Fix new empty array creation options default in Boolean filter #44

Closed amcsi closed 7 years ago

amcsi commented 8 years ago

See zendframework/zend-servicemanager#159

amcsi commented 8 years ago

@zf2timo I think that broke the unit tests where the class was constructed with a 0 intending to be the type

zf2timo commented 8 years ago

@amcsi yeah, you are right. LGTM.

amcsi commented 8 years ago

Hold on with this. As it's been brought to my attention, maybe it would be better to fix the core issue instead: https://github.com/zendframework/zend-servicemanager/issues/159#issuecomment-251312066

amcsi commented 8 years ago

Alternative fix in other project: zendframework/zend-servicemanager#164

amcsi commented 7 years ago

Closing this, because zendframework/zend-servicemanager#164 makes this PR not needed anymore.

You should all upgrade to the latest Service Manager release of 2.7.8 https://github.com/zendframework/zend-servicemanager/releases/tag/release-2.7.8