zendframework / zend-filter

Filter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
68 stars 35 forks source link

Ensure `filters` config is honored in non-zend-mvc contexts #56

Closed weierophinney closed 7 years ago

weierophinney commented 7 years ago

Per https://discourse.zendframework.com/t/validatormanager-not-calling-custom-validator-factory/109/5?u=matthew the filters config key is not honored currently unless the application is within a zend-mvc context. This is due to the fact that Zend\Filter\Module wires configuration for the Zend\ModuleManager\Listener\ServiceListener in order to push merged service configuration into the plugin during bootstrap; no similar logic is available when not in a zend-mvc context, however.

This patch fixes that situation by modifying the FilterPluginManagerFactory to do the following:

weierophinney commented 7 years ago

Test failures are all on lowest, due to zend-servicemanager test expectation updates to use PHPUnit 5.7/6.0 expectException syntax within the FilterPluginManagerCompatibilityTest, which is unrelated. When run manually against an earlier zend-servicemanager version, the new tests pass.