search

zendframework / zend-form

Form component from Zend Framework
BSD 3-Clause "New" or "Revised" License
69 stars 87 forks source link

Fix styles and put comma after array last element #209

Closed maestroevn closed 5 years ago

weierophinney commented 5 years ago

zend-coding-standard v2 will actually enforce alignment of assignment operators. As such, going to close this, as it will be changed back once we adopt that version.

maestroevn commented 5 years ago

@weierophinney I thought we are using PSR-1 PSR-2 coding standards. Why develop zend coding standards when there is already developed, well documented, industry accepted coding standard?

weierophinney commented 5 years ago

@tigranmaestro We're still compatible with PSR-1/PSR-2. We are offering a superset of additional guidelines we use to help the code read consistently. Most frameworks do this (the default php-cs-fixer set, for instance, is also a superset of PSR-1 and PSR-2).

FWIW, alignment of assignment operators is not even addressed in PSR-1/PSR-2. And having multiple ways they are approached (some aligned, some not) makes reviewing harder.