zendframework / zend-form

Form component from Zend Framework
BSD 3-Clause "New" or "Revised" License
69 stars 87 forks source link

Added minlength to the validTagAttributes array on multiple elements #211

Closed rolandoisidoro closed 5 years ago

rolandoisidoro commented 6 years ago

This PR refers to issue #206. It will allow developers to set minlength attribute on text, email, search, password, tel and url form elements, which will enable HTML5 minimum length validation.

froschdesign commented 6 years ago

@rolandoisidoro Please extend also the unit tests. Example:

https://github.com/zendframework/zend-form/blob/4419eef6dbe9d276e7e27c6a25f022be74534959/test/View/Helper/FormTextTest.php#L48-L81

rolandoisidoro commented 6 years ago

@froschdesign , just extended the tests you mentioned before and added missing tests for FormSearchViewHelper.

weierophinney commented 5 years ago

Thanks, @rolandoisidoro!