Fix validation of $creationOptions in ElementFactory

[TysonAndre]

In setCreationOptions(array $options), a TypeError would be thrown if it was anything other than an array.

Move the exceptions and traversable checks to the constructor.

(This impossible condition was detected by Phan)

Provide a narrative description of what you are trying to accomplish:

• [x] Are you fixing a bug?

  • [x] Detail how the bug is invoked currently. Calling __construct with Traversable
  • [x] Detail the original, incorrect behavior. `__construct would throw a TypeError if passed a Traversable, contrary to documentation
  • [x] Detail the new, expected behavior. __construct will convert traversables to arrays.
  • [x] Base your feature on the master branch, and submit against that branch.
  • [x] Add a regression test that demonstrates the bug, and proves the fix.
  • [ ] Add a CHANGELOG.md entry for the fix.

• [ ] Are you creating a new feature?

  • [ ] Why is the new feature needed? What purpose does it serve?
  • [ ] How will users use the new feature?
  • [ ] Base your feature on the develop branch, and submit against that branch.
  • [ ] Add only one feature per pull request; split multiple features over multiple pull requests
  • [ ] Add tests for the new feature.
  • [ ] Add documentation for the new feature.
  • [ ] Add a CHANGELOG.md entry for the new feature.

• [ ] Is this related to quality assurance?

• [ ] Is this related to documentation?

[TysonAndre]

Okay. Without this change to src/, the unit test I added would fail.

I don't see many uses of new ElementFactory directly after a quick search, and none of them had args.

There was 1 error:

1) ZendTest\Form\FormElementManagerTest::testCreationOptionsHandled
TypeError: Argument 1 passed to Zend\Form\ElementFactory::setCreationOptions() must be of the type array, object given, called in /path/to/zend-form/src/ElementFactory.php on line 41

/path/to/zend-form/src/ElementFactory.php:119
/path/to/zend-form/src/ElementFactory.php:41
/path/to/zend-form/test/ElementFactoryTest.php:36
/path/to/zend-form/test/ElementFactoryTest.php:26

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

[michalbundyra]

Thanks, @TysonAndre!