search

zendframework / zend-http

Http component from Zend Framework
BSD 3-Clause "New" or "Revised" License
134 stars 85 forks source link

Add to Proxy adapter all the options of the Socket adapter #109

Closed mlocati closed 7 years ago

mlocati commented 7 years ago

sslcafile and sslverifypeername were present in the Socket adapter but not in the Proxy adapter.

We need all the options in order to avoid PHP warnings about accessing invalid array keys.

Xerkus commented 7 years ago

@mlocati please add test that ensures all of the socket config options are present in proxy

mlocati commented 7 years ago

@Xerkus done.

Xerkus commented 7 years ago

Do you really need those proxies? getConfig() could work just as well

mlocati commented 7 years ago

@Xerkus Of course you're right... I looked at the Proxy methods only and I didn't found a way to get the $config property. But obviously the getConfig method of the Socket class works fine. PR updated.

Xerkus commented 7 years ago

looks good, thanks

Xerkus commented 7 years ago

one last thing, rebase it on master please. It is patch level change

mlocati commented 7 years ago

rebase it on master

@Xerkus done.