search

zendframework / zend-http

Http component from Zend Framework
BSD 3-Clause "New" or "Revised" License
134 stars 85 forks source link

cast to (int) for Curl adapter timeout config #121

Closed samsonasik closed 5 years ago

samsonasik commented 7 years ago

same as what applied into Socket adapter

Xerkus commented 7 years ago

What is the reason for accepting non-integer timeout values? I would say exception should be thrown instead.

samsonasik commented 7 years ago

just for consistent with socket adapter. if it should be get exception, the in socket adapter should get exception as well?

Xerkus commented 7 years ago

That would be my preference, yes. I will need to look into it sometime later, may be i don't see something.

weierophinney commented 5 years ago

Thanks, @samsonasik!