search

zendframework / zend-http

Http component from Zend Framework
BSD 3-Clause "New" or "Revised" License
134 stars 85 forks source link

Fluent Stream::setCleanup() #141

Closed lionelgaillard closed 6 years ago

lionelgaillard commented 6 years ago

Because Stream::setCleanup() was not returning $this, it was breaking the fluent interface.

michalbundyra commented 6 years ago

@lionelgaillard As I remember we are dropping fluent interfaces, please see: https://discourse.zendframework.com/t/how-should-we-provide-return-type-declarations-for-fluent-interfaces/30/13 and @Ocramius blog post: https://ocramius.github.io/blog/fluent-interfaces-are-evil/

Please note that also setContentLength method (for example) does not return $this...

lionelgaillard-inexto commented 6 years ago

Ho ok...