phpstan fixes - Githubissues

zendframework / zend-http

Http component from Zend Framework

BSD 3-Clause "New" or "Revised" License

134 stars 85 forks source link

phpstan fixes #157

Open thomasvargiu opened 6 years ago

thomasvargiu commented 6 years ago

some fixes on PHPDoc
added checks on types when needed

Changed

Throw an exception when unable to uncompress response content
Relative URIs are not allowed anymore in Zend\Http\Client. Anyway, usage of relative URIs has no sense and no adapter can handle it.

Fixed

Fixed Zend\Http\Cookies::getAllCookies(Zend\Http\Cookies::COOKIE_STRING_ARRAY).
Fixed Zend\Http\Cookies::getAllCookies(Zend\Http\Cookies::COOKIE_STRING_CONCAT).
Fixed use of HTTP URIs with empty path in Request

weierophinney commented 5 years ago

Removing the milestone; I suspect this patch will take a bit of back and forth before it's ready, and we're otherwise ready for the 2.9.0 release. We can target 2.10.0 for this.

weierophinney commented 5 years ago

@thomasvargiu You will need to rebase against current develop before you start applying changes.

thomasvargiu commented 5 years ago

@thomasvargiu You will need to rebase against current develop before you start applying changes.

@weierophinney should I target develop branch for merge?

weierophinney commented 5 years ago

Yes, please.

On Sun, Jan 13, 2019, 6:04 AM Thomas Mauro Vargiu <notifications@github.com wrote:

@thomasvargiu https://github.com/thomasvargiu You will need to rebase against current develop before you start applying changes.

@weierophinney https://github.com/weierophinney should I target develop branch for merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-http/pull/157#issuecomment-453824021, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlVw0jtiMLKWbVU8T8dhB4rMJ0eWwAks5vCyDAgaJpZM4Xd9qx .

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-http; a new issue has been opened at https://github.com/laminas/laminas-http/issues/4.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-http. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-http to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-http.
In your clone of laminas/laminas-http, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.