fixed Content-Length header

zendframework / zend-http

Http component from Zend Framework

BSD 3-Clause "New" or "Revised" License

134 stars 85 forks source link

fixed Content-Length header #60

Closed ghost closed 8 years ago

ghost commented 8 years ago

It's no more possible to have a Content-Length header with NULL as value
allow Content-Length: 0, fixes #26
added ContentLength::setFieldValue()
throw exception on invalid Content-Type headers like Content-Type: 123.456
restructured unit tests

ezimuel commented 8 years ago

@DCMNMarc As I wrote in specific comments this PR should focus only on fixing #26. The other changes that you proposed should be done in a new PR as new feature. Thanks for your contribution!

Note: to fix #26 is enough to change this in constructor:

if ($value !== null) {
...

ezimuel commented 8 years ago

@DCMNMarc I fixed #26 issue with PR #87. Now, if you want you can focus on the new features proposed in this PR. Thanks again!

ezimuel commented 8 years ago

Closing this PR in favor of a new one @DCMNMarc.