search

zendframework / zend-http

Http component from Zend Framework
BSD 3-Clause "New" or "Revised" License
134 stars 85 forks source link

flatten cookies for header #92

Closed tflori closed 7 years ago

tflori commented 8 years ago

Fix issue #77

jaapio commented 8 years ago

Could you provide a unittest for this?

tflori commented 7 years ago

@jaapio I created a test can you please recheck?

jaapio commented 7 years ago

I can. But I won't be able to approve your pr since I'm not a zf maintainer.

Op do 8 dec. 2016 13:15 schreef tflori notifications@github.com:

@jaapio https://github.com/jaapio I created a test can you please recheck?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-http/pull/92#issuecomment-265726682, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAuUbKsKb5B47_XcFHq_bQpqw2BUH7qks5rF_T1gaJpZM4KiQ37 .

tflori commented 7 years ago

@weierophinney it would be greate if you could review this pr. thanks in advance.

tflori commented 7 years ago

@ezimuel I modified the function not to use pass by reference.

I don't know why coveralls shows a decreased coverage status - the function I added is tested. Nothing else changed.

ezimuel commented 7 years ago

@tflori thanks for your contribution! I improved the unit test with a bi-dimensional cookie array.