search

zendframework / zend-http

Http component from Zend Framework
BSD 3-Clause "New" or "Revised" License
134 stars 85 forks source link

Split timeout in connectTimeout/executeTimeout #98

Closed mlocati closed 7 years ago

mlocati commented 7 years ago

See https://github.com/zendframework/zend-http/issues/96

mlocati commented 7 years ago

@mlocati I did a first review of your PR. As commented in details, I think we can use the old parameter timeout instead of executetimeout.

Done in https://github.com/zendframework/zend-http/pull/98/commits/6da4e3dc5fcfca7636247a44bb451b6e97b3d149

The PR needs to be completed with unit test to cover the new features, can you add it?

I'm going to do this.

Moreover, the PR should be send to develop because this is a new feature. Thanks!

PR updated: now it's against develop

mlocati commented 7 years ago

The PR needs to be completed with unit test to cover the new features, can you add it?

Done in https://github.com/zendframework/zend-http/pull/98/commits/0bff41b0c09403473ac78ee3e53fb736da2bf0f7

ezimuel commented 7 years ago

@mlocati thanks for your contribution!