zendframework / zend-i18n

I18n component from Zend Framework
BSD 3-Clause "New" or "Revised" License
65 stars 49 forks source link

Add helper trait to provide type-hinting for zend-view #102

Closed thexpand closed 4 years ago

thexpand commented 6 years ago

In favor of the following proposal: zendframework/zend-view#102

thexpand commented 6 years ago

@froschdesign Travis build has failed with something like a timeout? Is there anything that we can do to re-run it or something?

froschdesign commented 6 years ago

This is an important enhancement for developers and should be mentioned in the documentation.

froschdesign commented 6 years ago

Btw. Please use the develop branch for new features.

https://github.com/zendframework/zend-i18n/blob/master/docs/CONTRIBUTING.md#what-branch-to-issue-the-pull-request-against

thexpand commented 6 years ago

@froschdesign The IntlDateFormatter class is used, but the ext-intl extension is not required in composer.json. The whole repository uses it, actually, so I think it's a good idea to add it (maybe in another PR, because it is a breaking change?)

froschdesign commented 6 years ago

@thexpand Already there as suggestion:

https://github.com/zendframework/zend-i18n/blob/c6c465ad5c7c9b93304f2a2832c9b4deafb3fcdf/composer.json#L33-L34

thexpand commented 6 years ago

@froschdesign I suggest adding the documentation as a sub-section of the main section View Helpers. We could name the sub-section: Auto-completion in templates or IDE auto-completion in templates. Which place do you think will be more appropriate - at the top or at the bottom of the view helpers? https://docs.zendframework.com/zend-i18n/view-helpers/

froschdesign commented 6 years ago

@thexpand

Which place do you think will be more appropriate - at the top or at the bottom of the view helpers?

At the top. (Later we will split the entire page and then we can also add an introduction like in other components,)

thexpand commented 6 years ago

@froschdesign I've added the documentation. Can you take a look so that I can copy-paste it to the other repositories' PRs for the HelperTrait?

thexpand commented 6 years ago

I have moved it in a block quote and applied the headings indentation - looks better now :+1:

weierophinney commented 4 years ago

Thanks, @thexpand!