zend-servicemanager is not a dev dependency

zendframework / zend-inputfilter

InputFilter component from Zend Framework

BSD 3-Clause "New" or "Revised" License

64 stars 50 forks source link

zend-servicemanager is not a dev dependency #125

Closed abacaphiliac closed 7 years ago

abacaphiliac commented 7 years ago

zendframework/zend-servicemanager and container-interop/container-interop are explicitly referenced by several classes in this package, so they should always be required.

i included zendframework/zend-inputfilter in a package without requiring zend-servicemanager and the input filter factory crashed due to the unsatisfied dependency.

abacaphiliac commented 7 years ago

@samsonasik i have reverted the .gitignore and composer.lock file changes. i'm curious, what is the reason for committing a lock file in a sub-package? i'm accustomed to committing the lock at the application level only.

weierophinney commented 7 years ago

@abacaphiliac —

The composer.lock is committed, as it helps us support both the lowest and highest supported constraints for dependencies. If tests fail at lowest, we know we're using newer features of a library, and may need to either bump the minimum version, or modify the code to use the older API. If tests fail at a higher version, we may be encountering a bug introduced by the library. Finally, having the lock means contributors are then testing on known good versions, and can expect not to encounter either of the above problems when doing initial work.
zend-servicemanager is already in the suggestions for this component, and notes it is needed for plugin manager support. Since usage of the plugin manager is optional (most filters can be used standalone; even when using the filter chain, you can attach instances directly and not require the plugin manager), it is not a required dependency. As such, I'm closing this request, as this was done intentionally.

abacaphiliac commented 7 years ago

@weierophinney thanks for the thorough response. i understand.

samsonasik commented 7 years ago

I think @weierophinney has reason for it. Also, this is not part of this PR

Senin, 24 Oktober 2016, Timothy Younger notifications@github.com menulis:

@samsonasik https://github.com/samsonasik i have reverted the .gitignore and composer.lock file changes. i'm curious, what is the reason for committing a lock file in a sub-package? i'm accustomed to committing the lock at the application level only.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendframework/zend-inputfilter/pull/125#issuecomment-255600971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcDgA6aJuR0difFgEEBIJeIO3EVCOq8ks5q25aKgaJpZM4KeAKX .

Warm regards,

Abdul Malik Ikhsan