Add PHP 7.2 support, drop HHVM

zendframework / zend-inputfilter

InputFilter component from Zend Framework

BSD 3-Clause "New" or "Revised" License

64 stars 50 forks source link

Add PHP 7.2 support, drop HHVM #142

Closed Slamdunk closed 6 years ago

Slamdunk commented 7 years ago

[x] Cherry-pick https://github.com/zendframework/zend-inputfilter/pull/141
[x] Adopt recent .travis.yml ZF standards (zend-session/.travis.yml picked)
[x] Drop HVVM
[x] Test PHP 7.2
[x] Add partial PHP 7.2 support
1. Fatal error: Declaration of Zend\InputFilter\CollectionInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /tmp/zend-inputfilter/src/CollectionInputFilter.php

froschdesign commented 7 years ago

The failing tests for the nightly build are related to Zend\Validator\EmailAddress and idn_to_ascii.

https://travis-ci.org/zendframework/zend-inputfilter/jobs/245787768#L381

Slamdunk commented 7 years ago

@froschdesign thank you, https://github.com/zendframework/zend-validator/pull/175

Slamdunk commented 6 years ago

Note that Because https://github.com/zendframework/zend-inputfilter/blob/9569f7e18122d57b66c95ff2f02472937f26db46/composer.json#L18 And zend-validator compatibility with PHP 7.2 was introduced only in zend-validator ^2.10 release

michalbundyra commented 6 years ago

@Slamdunk Maybe then we should bump requirements in composer.json?

Slamdunk commented 6 years ago

This is a decision that I cannot take, only maintainers know the path of expected components support.

MatyCZ commented 6 years ago

Any ETA for merging this PR?

weierophinney commented 6 years ago

@MatyCZ I'm merging it today, but it won't release yet, as I have a PR or two I'm sitting on for the 2.8.0 release (primarily waiting for docs). This cannot release in a bugfix release, as it drops support for HHVM.

weierophinney commented 6 years ago

Thanks, @Slamdunk!