fix proto for PHP 7.2 - Githubissues

zendframework / zend-inputfilter

InputFilter component from Zend Framework

BSD 3-Clause "New" or "Revised" License

64 stars 50 forks source link

fix proto for PHP 7.2 #150

Closed remicollet closed 6 years ago

remicollet commented 6 years ago

Discovered in Fedora QA with PHP 7.2.0RC4 https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-inputfilter?collection=f28

PHP Fatal error: Declaration of Zend\InputFilter\CollectionInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /builddir/build/BUILDROOT/php-zendframework-zend-inputfilter-2.7.4-2.fc28.noarch/usr/share/php/Zend/InputFilter/CollectionInputFilter.php on line 296

remicollet commented 6 years ago

See #140

remicollet commented 6 years ago

BTW, already part of #142 (I should I check pending PR first...)

weierophinney commented 6 years ago

Closing, as this is included in #142. I'm waiting to do 7.2 support for the 2.8.0 release, as we'll also be dropping support for HHVM at the same time.