zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

Rename InputFilterPluginManager as PluginManager #34

Closed Maks3w closed 9 years ago

Maks3w commented 9 years ago

It's redundant to repeat component name in class name.

This large class name produces inconsistent method names in consumer classes (see Factory::setInputFilterManager)

gianarb commented 9 years ago

:+1:

weierophinney commented 9 years ago

Regardless of whether or not this is targeted at 3.0, is still a BC break, and should be labeled as such, as the change has ramifications:

One reason to potentially keep the name is that this is one plugin manager that often is referenced with others in the same connect: validator, filter, and form plugin managers. Keeping the name prevents the necessity of aliasing when these are referenced together.

Maks3w commented 9 years ago

I did remove the BC break label because this can be done in bc way and do the removal of the old class on v3

Maks3w commented 9 years ago

This is a naming convention so I agree with that.