search

zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

Input Fallback Value is not merged on Input::merge() #35

Open Maks3w opened 9 years ago

Maks3w commented 9 years ago

I think the fallback value should be replaced when merge is done.

svycka commented 9 years ago

I think this is bug not a BC break. I don't think someone is relying on current behavior. But yes also it can be BC break, but very unlikely. This is not documented, no tests.. so I think we don't need to wait till 3.0

zluiten commented 8 years ago

Imho the intended behavior of merge is to also take care of the fallback value. Therefore this qualifies as a bugfix. I really would like to see this fixed asap.

        if ($input instanceof Input && $input->hasFallback()) {
            $this->setFallbackValue($input->getFallbackValue());
        }

ping @Maks3w

Maks3w commented 8 years ago

Fallback feature and merge method exists since a long time and nobody appreciate this before. My conclusion any change in the current behavior introduces a BC break.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at https://github.com/laminas/laminas-inputfilter/issues/12.