search

zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

Remove test about Input setters permutation #40

Closed Maks3w closed 9 years ago

Maks3w commented 9 years ago

These tests asserts the state of Input is always the same not matter the order when invoke the setters.

Sometime ago there was specific tweaks where setterA change the default value for propertyB. This feature was removed so this tests are verifing "Feature X" not longer exists.

This given me to think if we should to test every permutation on setters call and I found it's not. There is no reason for to test a feature not longer exists.

PD: setRequired is already verified by testRequiredFlagIsMutable

Maks3w commented 9 years ago

Ping @weierophinney

Maks3w commented 9 years ago

Extra: If someone want to test the setters permutations then there is no need to call isValid, just query the object under test and verify it has the desired state (i.e. setA setB setC > assert GetA,GetB GetC)