search

zendframework / zend-inputfilter

InputFilter component from Zend Framework
BSD 3-Clause "New" or "Revised" License
64 stars 50 forks source link

Fix #28 - NotEmpty validation message cannot be localized #67

Closed stefanotorresi closed 8 years ago

stefanotorresi commented 8 years ago

even after #60, #61 and #63, issue #28 was still reproducible.

Related:

Maks3w commented 8 years ago

Please take a look to #62

stefanotorresi commented 8 years ago

@Maks3w it comes down to what version are you targeting with that PR. To me it looks like it's a bc break, while this PR is completely BC safe. Your call either way, as far as I'm concerned I have nothing more to add to this one, as I have addressed @weierophinney request to pull the validator from the plugin manager in the last commit.

Slamdunk commented 8 years ago

So @Maks3w , is this PR going to be merged please?

You can tag this in a minor release, and then think about #62 for a future mid-release. As a non-english-site user, our business apps really need this.

Maks3w commented 8 years ago

/fw @weierophinney

weierophinney commented 8 years ago

@Maks3w Are you wanting me to review this one or #62?

Maks3w commented 8 years ago

@weierophinney #62 still being a PoC for future developments. I don't consider it enough stable. The point I forward this discussion to you is for assign you all the issues and PRs open about the translation of this message.

weierophinney commented 8 years ago

@Maks3w Could you maybe curate a list for me?

Maks3w commented 8 years ago

@weierophinney I've updated the PR comment with a list of related issues/PRs

johnnymallie commented 8 years ago

Hi ! Any news about the release ? Looking forward to it :)

jaapio commented 8 years ago

It would be very helpfull for us to have this merged. It provides a solution to a very common problem. I know this is not the ideal solution but it is a step forward in the right direction

Slamdunk commented 8 years ago

:bell:

stefanotorresi commented 8 years ago

@weierophinney I think this is safe to merge for now, and then we can start working with a broader solution encompassing all the other related issues, but ultimately it's your call, of course :) Let me know if you need me to change anything.